Fix fields error bug (#1843)

superdesk · Aug 18, 2023 · bfbe23b · bfbe23b
1 parent 9571a01
commit bfbe23b
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/client/components/fields/editor/base/text.tsx b/client/components/fields/editor/base/text.tsx
@@ -106,7 +106,6 @@ export class EditorFieldText extends React.Component<IEditorFieldTextProps, ISta
                 testId={this.props.testId}
                 refNode={this.node}
                 noPadding={this.props.noPadding}
-
             >
                 {this.state.suggestions.length === 0 ? (
                     <Input
@@ -116,11 +115,10 @@ export class EditorFieldText extends React.Component<IEditorFieldTextProps, ISta
                         label={this.props.label}
                         required={this.props.required ?? this.props.schema?.required}
                         disabled={this.props.disabled}
-                        invalid={this.props.invalid ?? (error != null && this.props.showErrors)}
                         maxLength={this.props.maxLength ?? this.props.schema?.maxlength}
                         info={this.props.info}
                         inlineLabel={this.props.inlineLabel}
-                        error={this.props.showErrors && error}
+                        error={this.props.showErrors ? error : undefined}
                         onChange={this.onChange}
                     />
                 ) : (
@@ -133,7 +131,7 @@ export class EditorFieldText extends React.Component<IEditorFieldTextProps, ISta
                         invalid={this.props.invalid ?? (error != null && this.props.showErrors)}
                         info={this.props.info}
                         inlineLabel={this.props.inlineLabel}
-                        error={this.props.showErrors && error}
+                        error={this.props.showErrors ? error : undefined}
                         onChange={this.onChange}
                         items={this.state.suggestions}
                     />