Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker components for subctl deploy-broker should be a set #141

Open
mkolesnik opened this issue Jun 30, 2022 · 1 comment
Open

Broker components for subctl deploy-broker should be a set #141

mkolesnik opened this issue Jun 30, 2022 · 1 comment
Assignees
Labels
bug Something isn't working confirmed For issues and PRs which we definitely want (disables the stale bot) help wanted Extra attention is needed priority:low

Comments

@mkolesnik
Copy link
Contributor

Came across this when mucking about with make deploy using=globalnet,lighthouse in the operator repo.

What happened:
The broker has components listed twice:

kubectl --context=cluster1 describe brokers -n submariner-k8s-broker
Name:         submariner-broker
Namespace:    submariner-k8s-broker
Labels:       <none>
Annotations:  <none>
API Version:  submariner.io/v1alpha1
Kind:         Broker
Metadata:
  Creation Timestamp:  2022-06-30T08:00:01Z
  Generation:          1
  Managed Fields:
    API Version:  submariner.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        .:
        f:components:
        f:defaultGlobalnetClusterSize:
        f:globalnetCIDRRange:
        f:globalnetEnabled:
    Manager:         subctl
    Operation:       Update
    Time:            2022-06-30T08:00:01Z
  Resource Version:  990
  UID:               3f101c0d-8f9c-4388-adc9-025151f2cbea
Spec:
  Components:
    service-discovery
    connectivity
    service-discovery
    connectivity
  Default Globalnet Cluster Size:  65536
  Globalnet CIDR Range:            242.0.0.0/8
  Globalnet Enabled:               true
Events:                            <none>

This is due to it being specified twice (which is its own bug):

[07:59:33.917] [output]$ [cluster1] subctl deploy-broker --kubeconfig /go/src/github.com/submariner-io/submariner-operator/output/kubeconfigs/kind-config-cluster1 --repository localhost:5000 --version local --globalnet --components service-discovery,connectivity --components service-discovery,connectivity

What you expected to happen:
The components sent in the spec should be a set not an list.

Anything else we need to know?:
Not sure if this is can be enforced on the server side, but if it is we'll need a bug on the operator repo.

Environment:

  • Diagnose information (use subctl diagnose all):
  • Gather information (use subctl gather)
  • Cloud provider or hardware configuration:
  • Install tools:
  • Others:
@mkolesnik mkolesnik added the bug Something isn't working label Jun 30, 2022
@stale
Copy link

stale bot commented Oct 29, 2022

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 29, 2022
@mkolesnik mkolesnik added the confirmed For issues and PRs which we definitely want (disables the stale bot) label Oct 30, 2022
@dfarrell07 dfarrell07 added priority:low help wanted Extra attention is needed and removed wontfix This will not be worked on labels Nov 8, 2022
@tpantelis tpantelis self-assigned this Jun 24, 2024
@maayanf24 maayanf24 moved this to Todo in Submariner 0.19 Jun 25, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Backlog Oct 28, 2024
@tpantelis tpantelis moved this from Backlog to Next Version Candidate in Backlog Oct 28, 2024
@tpantelis tpantelis removed this from Backlog Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed For issues and PRs which we definitely want (disables the stale bot) help wanted Extra attention is needed priority:low
Projects
Status: Todo
Development

No branches or pull requests

3 participants