OneDrive Proxy #20
OneDrive Proxy #20
Conversation
(cherry picked from commit ee28c8e)
- cap lines at 100 characters - standardize to double-quotes
|
Do you have an example share for me to test with? I don't use OneDrive. |
| <p>Currently it supports imgur, OneDrive, nhentai and custom appropriately-formatted JSON hosted on GitHub Gists. This is an advanced feature and will be explained in detail below.</p> | ||
|
|
||
| <h2>Disclaimer regarding OneDrive shares</h2> | ||
| <p>OneDrive links provide user information (look for the "More Details" pane on the "Info" tab).<br>Keep that in mind if you intend to share Cubari links from that source.<br>We can't opt-out of receiving that information, so the best we can do is pinky-swear we don't even read it.</p> |
There was a problem hiding this comment.
I have a little fud about burying this in our "about" page wall of text when we're not the only ones that can read this information. The share URL should have a "source" button that reveals the original resource:
That original URL should in some way reveal the original source, which would also reveal the drive's owner.
I've seen gist owners not realizing that their GitHub accounts are publicly visible so I'm still a bit wary about this.
There was a problem hiding this comment.
I tried hijacking the function to add a new pop-up element exclusively for this disclaimer, but my frontend-fu wasn't strong enough. IIRC I managed to make it show up but broke the close button 😅.
Prototype parser proxy for OneDrive folders via shared links.
Included disclaimer to address PII concerns on #19
Tested Series and Chapter pages on both Reader and API endpoints
Closes #19