Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to reflect that django 'extends' now natively supports this feature. #35

Open
unexceptable opened this issue Jun 7, 2017 · 2 comments

Comments

@unexceptable
Copy link

It appears that Django does now support circular inheritance. Not sure when it was introduced (believe 1.10?), but testing version 1.11 using the extends tag on a template of the same name now works correctly and allows me to selectively override+extend that template in the same way that overextends does.

It would probably be good to add a note to the readme and pypi docs to reflect that, and suggest a migration path so that when users migrate to Django 1.11 (which they need to soon because of 1.8 LTS ending early next year), they can stop using this library.

After of course testing that the expected functionality is now in Django, otherwise if this library still does anything usefully different it would be worth noting that, otherwise you can probably issue a deprecation warning and drop support for newer releases of Django after 1.11 LTS.

Now if only the Django docs themselves were actually clear about the ability to do circular inheritance with a section that looked like your readme...

That said, thank you for this library! This was an amazingly useful thing for ages!

@julen
Copy link

julen commented Dec 9, 2017

That's been available since Django 1.9, it was https://code.djangoproject.com/ticket/15053

@stefanw
Copy link
Contributor

stefanw commented Nov 22, 2018

I changed the tests to use extends instead of overextends and they pass since Django 1.9: https://travis-ci.org/stefanw/django-overextends/builds/458417914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants