Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up outdated mention of "max quorum nesting level = 2" #4541

Open
jayz22 opened this issue Nov 14, 2024 · 0 comments
Open

Clean up outdated mention of "max quorum nesting level = 2" #4541

jayz22 opened this issue Nov 14, 2024 · 0 comments
Labels
cleanup refactoring or other internal improvements docs issue/PR that affects documentation help wanted

Comments

@jayz22
Copy link
Contributor

jayz22 commented Nov 14, 2024

Description

The incorrect maximum nesting level of 2 are still being mentioned at least in a couple places, the XDR definitions of SCPQuorumSet and the example cfg file.

It was once a legacy requirement which later was invalidated with automatic quorum generation based on quality level, and was invalidated once again when CRITICAL quality was introduced. So the correct value should be 4 (as defined in

uint32 const MAXIMUM_QUORUM_NESTING_LEVEL = 4;
)

This issue tracks cleanup of any outdated mention of the wrong nesting level (this includes any code comments in the XDR, stellar-core code base including example cfg, and possibly the docs).

@jayz22 jayz22 added cleanup refactoring or other internal improvements docs issue/PR that affects documentation help wanted labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup refactoring or other internal improvements docs issue/PR that affects documentation help wanted
Projects
None yet
Development

No branches or pull requests

1 participant