Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle soroban loadgen modes misconfiguration gracefully #4473

Closed
marta-lokhova opened this issue Sep 19, 2024 · 0 comments · Fixed by #4559
Closed

handle soroban loadgen modes misconfiguration gracefully #4473

marta-lokhova opened this issue Sep 19, 2024 · 0 comments · Fixed by #4559
Assignees
Labels

Comments

@marta-lokhova
Copy link
Contributor

marta-lokhova commented Sep 19, 2024

Looks like core crashes if a soroban invoke is triggered on the node that didn't do invoke setup before. We should probably gracefully handle such a misconfiguration and propagate a useful error message back to the user instead of crashing

2024-09-19T00:34:08.389 GBL23 [Ledger INFO] Got consensus: [seq=32, prev=585e84, txs=0, ops=0, sv: [ SIGNED@bd-0 txH: e622ed, ct: 1726706047, upgrades: [ ] ]]
2024-09-19T00:34:08.392 GBL23 [Ledger INFO] Closed ledger: [seq=32, hash=c9c58d]
2024-09-19T00:34:13.019 GBL23 [Herder INFO] Armed with network upgrades: upgradetime=2024-09-19T00:34:00Z, {
    "configupgradesetkey": {
        "contractID": "CD2SNKASQKTLBUNWMZKZGOUXBYLY7RL5RUTMXTQRIZP7JCPLCX3L6ILS",
        "contentHash": "bf07addb011481ae5874f9eb95e07d738885f8830d2d923d1b16be2c175a4641"
    }
}
2024-09-19T00:34:14.625 GBL23 [Herder INFO] Quorum information for 31 : {"agree":23,"cost":318500,"delayed":0,"disagree":0,"fail_at":6,"hash":"39d898","lag_ms":103,"ledger":31,"missing":0,"phase":"EXTERNALIZE","validated":true}

2024-09-19T00:34:14.627 GBL23 [Ledger INFO] Got consensus: [seq=33, prev=c9c58d, txs=0, ops=0, sv: [ SIGNED@wx-2 txH: efb6eb, ct: 1726706053, upgrades: [ ] ]]
2024-09-19T00:34:14.629 GBL23 [Ledger INFO] Closed ledger: [seq=33, hash=466edb]
2024-09-19T00:34:15.538 GBL23 [default INFO] Performing maintenance
2024-09-19T00:34:15.538 GBL23 [History INFO] Trimming history <= ledger 0 (rmin=4294967295, qmin=33, lmin=0)
2024-09-19T00:34:19.875 GBL23 [Herder INFO] Quorum information for 32 : {"agree":23,"cost":210620,"delayed":0,"disagree":0,"fail_at":6,"hash":"39d898","lag_ms":103,"ledger":32,"missing":0,"phase":"EXTERNALIZE","validated":true}

2024-09-19T00:34:19.889 GBL23 [Herder INFO] Network upgrades cleared
2024-09-19T00:34:19.889 GBL23 [Ledger INFO] Got consensus: [seq=34, prev=466edb, txs=0, ops=0, sv: [ SIGNED@pn-0 txH: 348095, ct: 1726706059, upgrades: [{
    "configupgradesetkey": {
        "contractID": "CD2SNKASQKTLBUNWMZKZGOUXBYLY7RL5RUTMXTQRIZP7JCPLCX3L6ILS",
        "contentHash": "bf07addb011481ae5874f9eb95e07d738885f8830d2d923d1b16be2c175a4641"
    }
},  ] ]]
2024-09-19T00:34:19.889 GBL23 [Ledger INFO] Applying config upgrade: {
    "updatedEntry": [
        {
            "configSettingID": "CONFIG_SETTING_CONTRACT_MAX_SIZE_BYTES",
            "contractMaxSizeBytes": 128000
        },
        {
            "configSettingID": "CONFIG_SETTING_CONTRACT_COMPUTE_V0",
            "contractCompute": {
                "ledgerMaxInstructions": 2500000,
                "txMaxInstructions": 2500000,
                "feeRatePerInstructionsIncrement": 100,
                "txMemoryLimit": 200000000
            }
        },
        {
            "configSettingID": "CONFIG_SETTING_CONTRACT_LEDGER_COST_V0",
            "contractLedgerCost": {
                "ledgerMaxReadLedgerEntries": 3,
                "ledgerMaxReadBytes": 3200,
                "ledgerMaxWriteLedgerEntries": 2,
                "ledgerMaxWriteBytes": 256000000,
                "txMaxReadLedgerEntries": 3,
                "txMaxReadBytes": 3200,
                "txMaxWriteLedgerEntries": 2,
                "txMaxWriteBytes": 128000,
                "feeReadLedgerEntry": 5000,
                "feeWriteLedgerEntry": 20000,
                "feeRead1KB": 1000,
                "bucketListTargetSizeBytes": 32212254720,
                "writeFee1KBBucketListLow": 1000,
                "writeFee1KBBucketListHigh": 10000,
                "bucketListWriteFeeGrowthFactor": 1
            }
        },
        {
            "configSettingID": "CONFIG_SETTING_CONTRACT_HISTORICAL_DATA_V0",
            "contractHistoricalData": {
                "feeHistorical1KB": 100
            }
        },
        {
            "configSettingID": "CONFIG_SETTING_CONTRACT_EVENTS_V0",
            "contractEvents": {
                "txMaxContractEventsSizeBytes": 200,
                "feeContractEvents1KB": 200
            }
        },
        {
            "configSettingID": "CONFIG_SETTING_CONTRACT_BANDWIDTH_V0",
            "contractBandwidth": {
                "ledgerMaxTxsSizeBytes": 260000000,
                "txMaxSizeBytes": 130000,
                "feeTxSize1KB": 2000
            }
        },
        {
            "configSettingID": "CONFIG_SETTING_CONTRACT_DATA_KEY_SIZE_BYTES",
            "contractDataKeySizeBytes": 200
        },
        {
            "configSettingID": "CONFIG_SETTING_CONTRACT_DATA_ENTRY_SIZE_BYTES",
            "contractDataEntrySizeBytes": 2000
        },
        {
            "configSettingID": "CONFIG_SETTING_STATE_ARCHIVAL",
            "stateArchivalSettings": {
                "maxEntryTTL": 1054080,
                "minTemporaryTTL": 16,
                "minPersistentTTL": 4096,
                "persistentRentRateDenominator": 252480,
                "tempRentRateDenominator": 2524800,
                "maxEntriesToArchive": 100,
                "bucketListSizeWindowSampleSize": 30,
                "bucketListWindowSamplePeriod": 64,
                "evictionScanSize": 100000,
                "startingEvictionScanLevel": 6
            }
        },
        {
            "configSettingID": "CONFIG_SETTING_CONTRACT_EXECUTION_LANES",
            "contractExecutionLanes": {
                "ledgerMaxTxCount": 2000
            }
        }
    ]
2024-09-19T00:34:19.892 GBL23 [Ledger INFO] Closed ledger: [seq=34, hash=d7f425]
2024-09-19T00:34:25.252 GBL23 [Herder INFO] Quorum information for 33 : {"agree":23,"cost":287368,"delayed":0,"disagree":0,"fail_at":6,"hash":"39d898","lag_ms":103,"ledger":33,"missing":0,"phase":"EXTERNALIZE","validated":true}

2024-09-19T00:34:25.254 GBL23 [Ledger INFO] Got consensus: [seq=35, prev=d7f425, txs=0, ops=0, sv: [ SIGNED@sp-0 txH: 636111, ct: 1726706064, upgrades: [ ] ]]
2024-09-19T00:34:25.256 GBL23 [Ledger INFO] Closed ledger: [seq=35, hash=4b9285]
mCodeKey at simulation/LoadGenerator.cpp:389
Cannot provide readable stack trace. Use ParseDump.py to translate stack.
stellar-core() [0x96b49a]
stellar-core() [0x977601]
stellar-core() [0xef2fbb]
stellar-core() [0xef4224]
stellar-core() [0x754d0f]
stellar-core() [0x79091c]
stellar-core() [0x7940ce]
stellar-core() [0x79888c]
stellar-core() [0x16dc921]
stellar-core() [0x16e21b1]
stellar-core() [0x16e1d30]
stellar-core() [0x16f0fe3]
stellar-core() [0x16e5b46]
stellar-core() [0x16e5998]
stellar-core() [0x992d0b]
stellar-core() [0x75fc72]
stellar-core() [0x7dca3a]
stellar-core() [0x79aa1d]
stellar-core() [0x7bef49]
stellar-core() [0x7cc41f]
stellar-core() [0x84162e]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7fcde564f083]
stellar-core() [0x45aafe]
Aborted (core dumped)
+ CORE_EXIT_STATUS=134
+ killall5 -2
+ exit 134
@marta-lokhova marta-lokhova changed the title Crash in LoadGenerator after the Soroban upgrade Crash in LoadGenerator after Soroban upgrade Sep 19, 2024
@marta-lokhova marta-lokhova changed the title Crash in LoadGenerator after Soroban upgrade handle soroban loadgen modes misconfiguration gracefully Sep 20, 2024
@ThomasBrady ThomasBrady self-assigned this Nov 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2024
# Description

Resolves #4473

<!---

Describe what this pull request does, which issue it's resolving
(usually applicable for code changes).

--->

# Checklist
- [ ] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [ ] Rebased on top of master (no merge commits)
- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [ ] Compiles
- [ ] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants