This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Support validation of ".spec.valuesFrom" #25
Comments
@stefanprodan What's your opinion on that? I may try to implement it if you think it makes sense for the project. |
Yes I think it makes sense 👍 As for the language, I think you could write GH actions in Go but I didn't had time to see what options are there. |
Would be nice parser chartFileRef and use if exist. PR #32 covers it. |
jozala
added a commit
to avaleo/hrval-action-1
that referenced
this issue
Dec 11, 2020
I have finally implemented this feature and created pull request #57 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I would like to use hrval-action, but in my use case I am using ".spec.valuesFrom" to add values from Kubernetes secrets to application configuration. These values passed with "valuesFrom" are required in Helm chart so validation fails.
What I would propose is to have a separate directory with ConfigMaps and Secrets in the deployment repository where hrval-action would look for ConfigMaps and Secrets specified with ".spec.ValuesFrom". In my case - I will push Secrets with fake values and
flux.weave.works/ignore
set to "true" to this directory.Additional steps would be:
valuesFrom
from HelmReleasevaluesFrom
configmap or secret-f tempfile
tohelm template
commandWhat do you think about it?
Bonus question:
Is other language then Bash acceptable for this project? I can see Docker image is using Go.
The text was updated successfully, but these errors were encountered: