Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to display the phenotypes in sorted order? #225

Open
jielab opened this issue May 23, 2024 · 9 comments
Open

how to display the phenotypes in sorted order? #225

jielab opened this issue May 23, 2024 · 9 comments

Comments

@jielab
Copy link

jielab commented May 23, 2024

Hi, there

Please see the screenshot below. The phenotypes are not sorted. They are sorted in my pheno-list.json file. This makes it difficult to find a target phenotype.

image

Thanks!

jie

@pjvandehaar
Copy link
Collaborator

pjvandehaar commented May 23, 2024

I don't understand what you're saying.

Your bug reports tend to be far below average. Please do better.

@jielab
Copy link
Author

jielab commented May 23, 2024

Sorry that I did not show the full screen on the previous screenshot.
Please see the updated screenshot below.

As you see, the second column "Phenotype" is not sorted.
How to make these phentoypes appear in order?

Thank you & best regadrs,
Jie

image

@pjvandehaar
Copy link
Collaborator

The phenotypes are sorted by pvalue. You can change the order of generated-by-pheweb/phenotypes.json. If that doesn't work, then look in templates/phenotypes.html and search for the word "sort".

@jielab
Copy link
Author

jielab commented May 25, 2024

Thanks. The pheweb/phenotypes.json file only has 1 line, looking quite complicated. I will not edit it to avoid making a mess. Ideally, it would be great that users could click the Category or Phenotype in the header row, to sort the phenotype list table.

I now got another displaying issue. Please see the screenshot below. Somehow there is NO manhattan plot and top table, even though there are some SNPs with P-value < 5E-08. Is this possibly due to the fact that might be NA or NaN values in my P-value column?

Thanks!

Jie

image

@pjvandehaar
Copy link
Collaborator

If you send a pull request for sortable tables I'll merge it.

For the missing manhattan plot, you should open the browser console and look for an error there.

@jielab
Copy link
Author

jielab commented May 25, 2024

Once I click the "new pull request", I was directed to a page shown as below.
image

Does this mean that I need to write some script to get this done and then you guys review it and approve/disapprove it? I thought that "create a pull request" is like "create a feature request ticket" ...
Anyway, I don't know how to write this type of code...

Regarding you reply: ”For the missing manhattan plot, you should open the browser console and look for an error there“, apparently I did not see any error message on the web browser. I attached the full screenshot in my last message, which is a screenshot of the browser console.

If you could kindly point me to the exact place (for pull request, and for browser console error), I would deeply appreciate.

Best regards,
Jie

1 similar comment
@jielab
Copy link
Author

jielab commented May 25, 2024

Once I click the "new pull request", I was directed to a page shown as below.
image

Does this mean that I need to write some script to get this done and then you guys review it and approve/disapprove it? I thought that "create a pull request" is like "create a feature request ticket" ...
Anyway, I don't know how to write this type of code...

Regarding you reply: ”For the missing manhattan plot, you should open the browser console and look for an error there“, apparently I did not see any error message on the web browser. I attached the full screenshot in my last message, which is a screenshot of the browser console.

If you could kindly point me to the exact place (for pull request, and for browser console error), I would deeply appreciate.

Best regards,
Jie

@jielab
Copy link
Author

jielab commented May 25, 2024

Once I click the "new pull request", I was directed to a page shown as below.
image

Does this mean that I need to write some script to get this done and then you guys review it and approve/disapprove it? I thought that "create a pull request" is like "create a feature request ticket" ...
Anyway, I don't know how to write this type of code...

Regarding you reply: For the missing manhattan plot, you should open the browser console and look for an error there, apparently I did not see any error message on the web browser. I attached the full screenshot in my last message, which is a screenshot of the browser console.

If you could kindly point me to the exact place (for pull request, and for browser console error), I would deeply appreciate.

Best regards,
Jie

@pjvandehaar
Copy link
Collaborator

No, sorry, I don't have time to teach you these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants