Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Classes as Needed #120

Open
2 tasks done
Pheotis opened this issue Feb 25, 2022 · 3 comments
Open
2 tasks done

Split Classes as Needed #120

Pheotis opened this issue Feb 25, 2022 · 3 comments
Assignees
Labels
enhancement A suggested addition to the plugin. On Hold! Something is currently preventing us from working on this; we will work on it when we can! REWRITE This task/issue only applies to the rewritten version of the plugin (currently in ALPHA)

Comments

@Pheotis
Copy link

Pheotis commented Feb 25, 2022

Major development efforts are currently underway for the final stages of the rewrite.
It is likely that some classes will need to be split for clarity.

Such classes, split rationales, and implementation efforts, will be tracked via this ticket.

Classes that need to be split:

@Pheotis Pheotis added enhancement A suggested addition to the plugin. REWRITE This task/issue only applies to the rewritten version of the plugin (currently in ALPHA) TMS A task related to the most recent TMS run. labels Feb 25, 2022
@Pheotis Pheotis added this to the 1.0.0.5 milestone Feb 25, 2022
@EpicKnarvik97
Copy link
Collaborator

EpicKnarvik97 commented Mar 7, 2022

We have a bunch of large classes that should be split to reduce complexity and improve readability and maintainability. Here is a list of large classes:

  • PortalDatabaseAPI.java
  • Stargate.java
  • Gate.java
  • AbstractPortal.java
  • SQLQueryGenerator.java
  • BlockEventListener.java
  • DatabaseTester.java
  • NetworkedPortal.java

For some, it might make sense to split into two classes, but for others it would make sense to move methods to other classes or to a helper class.

@Pheotis Pheotis pinned this issue Mar 15, 2022
@Pheotis Pheotis added On Hold! Something is currently preventing us from working on this; we will work on it when we can! and removed TMS A task related to the most recent TMS run. labels May 9, 2022
Thorinwasher added a commit that referenced this issue May 24, 2022
Thorinwasher added a commit that referenced this issue May 24, 2022
Relates to issue #120

(Also ordered the .util folder a bit)
@Pheotis
Copy link
Author

Pheotis commented May 24, 2022

As this is an ongoing effort, going to detach this from 1.0.0.5

@Pheotis Pheotis removed this from the 1.0.0.5 milestone May 24, 2022
@Pheotis Pheotis unpinned this issue May 24, 2022
@Pheotis
Copy link
Author

Pheotis commented Jun 6, 2022

Added to milestone 1.1.0.0, with #185

@Pheotis Pheotis added this to the 0.1.0.0 milestone Jun 6, 2022
@Pheotis Pheotis modified the milestones: 1.1.0.0, Near-Future (1.1.X.X) Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggested addition to the plugin. On Hold! Something is currently preventing us from working on this; we will work on it when we can! REWRITE This task/issue only applies to the rewritten version of the plugin (currently in ALPHA)
Projects
Development

No branches or pull requests

3 participants