Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observations varies when fetched with two env methods #202

Open
yinhaoz opened this issue Sep 11, 2019 · 4 comments
Open

observations varies when fetched with two env methods #202

yinhaoz opened this issue Sep 11, 2019 · 4 comments

Comments

@yinhaoz
Copy link

yinhaoz commented Sep 11, 2019

Hi there,

I used the following two methods to obtain the observations and get slightly different results:
obs_list, reward, done, info = env.step(action, project=True, obs_as_dict=False).
Just after this line, use another function to get observation,
obs_list2 = env.get_observation().
But obs_list is not equal to obs_list2, with abs error around 1e-4. Not sure what happens between these two lines that changes the observation values.

@smsong
Copy link
Collaborator

smsong commented Sep 29, 2019

@bmmi Sorry for the delayed response. The errors in v_tgt_field are due to the observation giving v_tgt_field based on the previous position. Thus, you should not see errors in other fields. Please let us know if this description does not match your observations.
We are aware of the lag in v_tgt_field. We thought a good solution should not be sensitive to how v_tgt_field is updated but will consider fixing it (or at least will make .get_observation() to give the correct values) in Round 2.

@smsong
Copy link
Collaborator

smsong commented Oct 5, 2019

@kiwi-byte This is not the same issue as #199, which was about the differences in docker and server submissions. #199 is fixed.

@smsong
Copy link
Collaborator

smsong commented Oct 6, 2019

@bmmi The v_tgt_field lagging issue is solved in a new commit: 1e0053e
It will be applied for Round 2 (not applied to the server yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@smsong @yinhaoz and others