Feat/rpc endpoints to fetch data from key

[hugocaillard]

Description

Add two new endpoints:

• /v2/clarity_marf_value/:clarity_marf_key
• /v2/clarity_metadata/:principal/:contract_name/:clarity_metadata_key

I'm currently working on a Clarinet feature that allows to simulate running (or, said differently, to fork the mainnet state in the simnet data store). This requires the ability to fetch values from marf and metadata keys.

These new endpoints are similar to already existing endpoint (such as getdatavar, getmapentry, getcontractsrc, etc).

Applicable issues

N/A

Additional info (benefits, drawbacks, caveats)

Read more about this feature in the Clarinet issue: hirosystems/clarinet#1503

I confirmed that the 2 new endpoints allow to achieve the desired goal by running a local devnet with these changes and forking the Clarinet simnet state from it.

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)

[hugocaillard]

Thanks for the reviews @jcnelson 🙏
I marked as resolved all of the addressed comment
Re-requested Brice review as well since it was dismissed, but he already approved earlier.

[obycode]

🎉

[hugocaillard]

@jcnelson I'm actually seeing something weird with the last test I added.

If I add a request after this call, or if I add a previous request hitting this code path (such as a request vm-metadata::9::invalid-contract-metadata-key, the following request don't work and this assertion fails.

Is it possible that this code path breaks the test runner?
It works just fine in practice when calling this endpoint

[jcnelson]

@hugocaillard Can you push a test case so I can take a look?

[jcnelson]

Placing a hold on this until we get further clarity from @hugocaillard

[hugocaillard]

@jcnelson
I added this test:

stacks-core/stackslib/src/net/api/tests/getclaritymetadata.rs

Lines 267 to 274 in c9d5295

	let request = StacksHttpRequest::new_getclaritymetadata(
	addr.into(),
	StacksAddress::from_string("ST2DS4MSWSGJ3W9FBC6BVT0Y92S345HY8N3T6AV7R").unwrap(),
	"hello-world".try_into().unwrap(),
	"vm-metadata::9::contract-size".to_string(),
	TipRequest::UseLatestAnchoredTip,
	);
	requests.push(request);

Which is a copy of the first request (L217).

But any request after the last one fails

[obycode]

LGTM!