-
Notifications
You must be signed in to change notification settings - Fork 540
Add .gitconfig support #760
Comments
To clarify, are you referring to the system and global git configuration files (i.e. the ones accessed in From
|
I think the Currently there code to pull the We probably do want to modify |
I am speaking of the global and system configurations, which are not currently being read. I did read through the Maybe we could have three internal structs, The troublesome marshaling code would be limited to the local config file. I have no problem with that since anyone wanting to programmatically modify the global and system configurations could use some out of band mechanism. If such functionality were desired, things could be done slightly differently. Using I don't see options for |
Actually, I'm quite fond of something like:
Then one could make calls such as
|
Can I get a 👍 from a Spaniard? :) Is there anything you all would like to see before I start tinkering with this? |
I'm going to start tinkering with this. Not sure when it will get done so if someone wants to work on this, feel free to ping me. |
To me
seems more elegant. If you don't want to use options you get the backwards compatible
|
What's the consensus on this? |
For consistency with other API methods we should probably stick with the |
Yep. I will. |
Is there any additional work being done on support the user's global gitconfig? I'm not sure where to even get started on it exactly but if someone could provide some guidance I'd like to take a look at it. |
I don't plan on it. It seems to me that the way go-git is currently architected makes it difficult. You're welcome to take a stab at it. |
Ref #603 : having any globally ignored files cause |
I am not sure how to use the #825 convenience methods:
I still get globally ignored files polluting the worktree status:
|
Workaround gist is here but this is excerpt:
|
Closes src-d#760 Signed-off-by: Dj Gilcrease <[email protected]>
Closes src-d#760 Signed-off-by: Dj Gilcrease <[email protected]>
Not sure if a first class object to represent the
.gitconfig
file should be provided or if the global config information should be squirreled away insideconfig.Config
. There is the~/.gitignore_global
file to consider as well.It seems to me that a first class object and storer interface is the way to go. These are real physical entities and they should have their counterparts in the
config
package.The text was updated successfully, but these errors were encountered: