Optionally define unique sensor id in inverter response decoder #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #112. It allows us to optionally define the unique sensor used by Home Assistant in the inverter's response decoder:
I believe explicitly defining the id is better than generating an id. An id generation algorithm would always depend on some value or order of a list, tuple or dict so that there is no guarantee that the generated id will not change in the future.
@squishykid How do you think about this solution? Let me know if you have a better idea!