Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing in SDK functions #144

Open
stavrostheocharis opened this issue Feb 18, 2023 · 2 comments
Open

Fix typing in SDK functions #144

stavrostheocharis opened this issue Feb 18, 2023 · 2 comments
Labels
good first issue Good for newcomers tech debt

Comments

@stavrostheocharis
Copy link
Contributor

Description
There is a need to change the typing in some functions

Solution

  • dict should be Dict with additional parts inside eg. Dict[str, float]
  • In some parts that None is returned or None is default, Union should be used to include the None value
@momegas momegas added the good first issue Good for newcomers label Feb 20, 2023
@momegas momegas moved this from Backlog to Planned in 🐻‍❄️ Whitebox - Issue tracking Feb 22, 2023
@momegas
Copy link
Member

momegas commented Feb 22, 2023

Related to #139

@sinnec
Copy link
Contributor

sinnec commented Mar 23, 2023

I think some further reading should be done about the return dict types: https://stackoverflow.com/questions/51291722/define-a-jsonable-type-using-mypy-pep-526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@momegas @sinnec @stavrostheocharis