Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .NET code example on the site #8

Closed
aradalvand opened this issue Aug 30, 2023 · 2 comments
Closed

Update .NET code example on the site #8

aradalvand opened this issue Aug 30, 2023 · 2 comments

Comments

@aradalvand
Copy link
Contributor

Not sure if this is the right place to post this but sqids-dotnet v2 has just been released which added support for all integral numeric types in .NET (e.g. int, long, etc.) — previously we only supported int.
This resulted in an API breaking change where the SqidsEncoder class now requires the user to specify a type argument upon instantiation; so, all three code snippets on the website need to be updated:

-  var sqids = new SqidsEncoder(...
+  var sqids = new SqidsEncoder<int>(...
@4kimov
Copy link
Member

4kimov commented Aug 30, 2023

Nice, thanks for all the work on the release + the heads up on the examples. Does it look better now?

@aradalvand
Copy link
Contributor Author

aradalvand commented Aug 30, 2023 •
edited
Loading

Yes, perfect, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aradalvand @4kimov