Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling Error: Abbot sends javascript-packed.js files when :used_packed == false #18

Open
FrozenCanuck opened this issue Dec 23, 2010 · 10 comments
Assignees

Comments

@FrozenCanuck
Copy link
Member

See:

1600bf2

Without the fix clobbering occurs causing unexpected results when running a SproutCore application. Fix has been applied; just need to be merged into origin/1-4-stable. Has been reviewed by Tom Dale.

@wagenet
Copy link
Contributor

wagenet commented Jan 5, 2011

Looks good to me, but I need to test it.

@FrozenCanuck
Copy link
Member Author

Sounds good. Tom ran the fix on his end and confirmed everything went as expected. Hopefully you'll get the same result.

@wycats
Copy link
Contributor

wycats commented Mar 16, 2011

Does this still need to be merged into 1-4-stable?

@FrozenCanuck
Copy link
Member Author

Yes, it should. I haven't merge the changes because I wanted some others to review. Peter and Tom both said my update looked fine. I can merge it in if you'd like.

@wagenet
Copy link
Contributor

wagenet commented Apr 28, 2011

Is this still an issue?

@FrozenCanuck
Copy link
Member Author

it is in 1.4.x, not sure about 1.5 since bundling has been replaced with modules. I haven't looked at the new module logic.

@wagenet
Copy link
Contributor

wagenet commented Apr 28, 2011

Ok, since it's only verified on 1.4 feel free to merge yourself or just close it. If there's also an issue on 1.5 we can make a new ticket for it.

@ghost ghost assigned FrozenCanuck Apr 28, 2011
@FrozenCanuck
Copy link
Member Author

Sure, I'll merge into 1.4-stable branch and close.

@wagenet
Copy link
Contributor

wagenet commented Apr 28, 2011

Guess we should release a new 1.4 at some point.

@wagenet
Copy link
Contributor

wagenet commented May 21, 2011

@FrozenCanuck, what's the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants