-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundling Error: Abbot sends javascript-packed.js files when :used_packed == false #18
Comments
Looks good to me, but I need to test it. |
Sounds good. Tom ran the fix on his end and confirmed everything went as expected. Hopefully you'll get the same result. |
Does this still need to be merged into 1-4-stable? |
Yes, it should. I haven't merge the changes because I wanted some others to review. Peter and Tom both said my update looked fine. I can merge it in if you'd like. |
Is this still an issue? |
it is in 1.4.x, not sure about 1.5 since bundling has been replaced with modules. I haven't looked at the new module logic. |
Ok, since it's only verified on 1.4 feel free to merge yourself or just close it. If there's also an issue on 1.5 we can make a new ticket for it. |
Sure, I'll merge into 1.4-stable branch and close. |
Guess we should release a new 1.4 at some point. |
@FrozenCanuck, what's the status of this? |
See:
1600bf2
Without the fix clobbering occurs causing unexpected results when running a SproutCore application. Fix has been applied; just need to be merged into origin/1-4-stable. Has been reviewed by Tom Dale.
The text was updated successfully, but these errors were encountered: