Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize callback and change login field on email change #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize callback and change login field on email change #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/models/spree/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class User < Spree::Base
acts_as_paranoid
after_destroy :scramble_email_and_password

before_validation :set_login
before_validation :set_login, if: :email_changed?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


users_table_name = User.table_name
roles_table_name = Role.table_name
Expand All @@ -35,7 +35,7 @@ def password_required?

def set_login
# for now force login to be same as email, eventually we will make this configurable, etc.
self.login ||= self.email if self.email
self.login = self.email
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinay-mittal @krzysiek1507 But then what is the meaning of keeping extra parameter as login.

Its realy good option to have login field separate, It useful in mobile to have mobile number for login parameters.

end

def scramble_email_and_password
Expand Down