Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod mod_marksOnGunExtended doesn't work after 1.11.0.0 updating. #70

Open
pechenkin opened this issue Dec 9, 2020 · 4 comments
Open

Comments

@pechenkin
Copy link

pechenkin commented Dec 9, 2020

Hello everyone! Mod marksOnGunExtended doesn't work after 1.11.0.0 updating.

2020-12-09 01:07:21.357: INFO: [START:]---------------- 2020-12-09 01:07:21.357: INFO: Traceback (most recent call last): 2020-12-09 01:07:21.357: INFO: File "hru-hru", line 131, in log 2020-12-09 01:07:21.357: INFO: File "source\mod_marksOnGunExtended.py", line 1577, in getRequiredLibraries 2020-12-09 01:07:21.357: INFO: TypeError: can only concatenate list (not "tuple") to list 2020-12-09 01:07:21.357: INFO: [END:]------------------

Apparently getRequiredLibraries() returns now list instead tuples. Here is the solution that works (for me):
`diff --git a/mod_marksOnGunExtended/source/mod_marksOnGunExtended.py b/mod_marksOnGunExtended/source/mod_marksOnGunExtended.py
old mode 100644
new mode 100755
index fe11b10..a26f999
--- a/mod_marksOnGunExtended/source/mod_marksOnGunExtended.py
+++ b/mod_marksOnGunExtended/source/mod_marksOnGunExtended.py
@@ -1574,7 +1574,7 @@ def makeHeaderVO(func, *args):
@inject.hook(LobbyEntry, '_getRequiredLibraries')
@inject.log
def getRequiredLibraries(func, *args):

  • return func(*args) + ('marksOnGun.swf',)
  • return func(*args) + ['marksOnGun.swf', '']

BigWorld.MoESetupSize = flash.setupSize`
Best regards!

@sashamilutka
Copy link

Обновы не будет?

@dkruben
Copy link
Contributor

dkruben commented Dec 17, 2020

Fixed :)

@sashamilutka
Copy link

sashamilutka commented Jan 3, 2021

Как можно изменить данный путь ("backgroundImage": "../maps/icons/quests/inBattleHint.png",) так, что бы можно было свой фон преминять.

How can I change this path ("background Image": "../maps/icons/quests/inbattlehint.png",) so that you can change your background.

@dkruben
Copy link
Contributor

dkruben commented Jan 10, 2021

@sashamilutka if in configs folder
"backgroundImage": '../../configs/spoter/marksOnGunExtended/[backgroudname].png',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants