-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load_nba_schedule() returns a broken data.table object #88
Comments
I cannot say honestly whether this ought to be considered a defect or a documentation error. I am unsure of what exactly is causing conflict but I think you have pinpointed it. I appreciate the note, as a user, I would expect that the tail() should work, so I will need to make some changes to fix. |
the easiest solition is not using data.table or remove it as I did in the topic. Where is come from? Do you use some hybrid of data.table and tidyverse? |
The reason many of the functions are so fast is due to the usage of data.table. It isn't an accident that we are using it. I'm not sure if I should do as you've done above or simply update the documentation to indicate it is a data.table object. clarifying* |
indicating that this is a data.table object doesn't solve the issue -- the final output object is broken. As a workaround: all user functions may return pure tibble objects but operate as it's faster. |
Describe the bug
load_nba_schedule()
returns somehow broken data.table object. The object throws an error ontail()
To Reproduce
load_nba_schedule(2019:2022) %>% tail()
Screenshots
there
as_tibble()
removesdata.table
among the object classes.UPD: the same problem is found for
load_nba_team_box()
andload_nba_player_box()
The text was updated successfully, but these errors were encountered: