Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing games for 2023 box scores #126

Open
TheMathNinja opened this issue Oct 23, 2023 · 3 comments
Open

Missing games for 2023 box scores #126

TheMathNinja opened this issue Oct 23, 2023 · 3 comments

Comments

@TheMathNinja
Copy link

Describe the bug
I'm not seeing any box scores for games played after April 2, 2023. The df omits the last week of the regular season and all playoff games.

To Reproduce
tictoc::tic()
progressr::with_progress({
nba_player_box <- hoopR::load_nba_player_box(2021:2023)
})
tictoc::toc()
check_2023 <- nba_player_box |>
filter(season == 2023)

Expected behavior
I'm expecting to see late regular season (final week) and postseason boxscores, but none exist in the df.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@bzigterman
Copy link

I'm also having the same issue

@saiemgilani
Copy link
Collaborator

saiemgilani commented Oct 26, 2023

~~Please update your package version to the development version:

remotes::install_github('sportsdataverse/hoopR')

We had an issue with the size of our data repository getting too large, resulting in the most up-to-date data now being at a different link. If the issue persists after that, let me know.~~

Update, forget I said that, this is an issue I need to go back and fix, apologies.

@saiemgilani
Copy link
Collaborator

This should now be resolved

remotes::install_github("sportsdataverse/hoopR")

And try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants