Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rinohtype #43

Open
brechtm opened this issue Apr 17, 2020 · 2 comments
Open

Add support for rinohtype #43

brechtm opened this issue Apr 17, 2020 · 2 comments

Comments

@brechtm
Copy link

brechtm commented Apr 17, 2020

Some investigation was done toward adding support for the rinoh (PDF) Sphinx builder. In support of anyone wanting to pursue this goal in the future, I'll link to the relevant issue here: brechtm/rinohtype#155.

@alexfargus
Copy link
Contributor

alexfargus commented Jul 3, 2021

I'm following up on this from the rinohtype end where I have manged to get a proof of concept working brechtm/rinohtype/issues/272.

I am now looking for a home for my plantuml specific changes. The approach that I have taken is to use a SphinxPostTransform object to convert the plantuml nodes into standard docutils image nodes. See example.

This avoids needing to import any rinohtype specific classes, and I believe should be a generic approach for any currently unsupported builder. However it is a significantly different approach to the current implementation in sphinxcontrib-plantuml. With this is mind, and before I spend significant effort, I would like to know wherther a PR adding support in this way be welcomed here or should I look elsewhere?

@yuja
Copy link
Collaborator

yuja commented Jul 4, 2021

@alexfargus I'm not an expert of sphinx, but your approach looks way nicer than the current node substitution logic, which is based off the graphviz extension in sphinx 0.9 era.
I'm happy to take patches that modernize the current codebase.

If you can, please start with a few small commits that just fixes rinohtype support by using the modern API. I'm not willing to review a single big commit that refactors everything. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants