feat: format transform #1094
Open
feat: format transform #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeHagar
force-pushed
the
format-command
branch
from
2120d1a
to
f13f06b
Compare
LukeHagar
force-pushed
the
format-command
branch
from
f13f06b
to
0aefd26
Compare
| var unknownOrder = []string{} | ||
|
|
||
| // Orders contains the order of keys for each node type | ||
| type Orders struct { |
There was a problem hiding this comment.
Honestly not entirely sure why this is necessary when the individual slices and their existing names are just as clear
There was a problem hiding this comment.
It was much easier to use this when adding each level, and the logic for determining the order to use completely changed a few times as I realized some silly mistakes in the initial implementation.
Happy to simplify if needed.
|
Added a whole document test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new command to format OpenAPI documents and includes corresponding tests. The most important changes include adding the
formatCmdcommand, implementing therunFormatfunction, and creating tests to ensure the formatting works correctly.New command for formatting OpenAPI documents:
cmd/openapi/transform.go: Added theformatCmdcommand to thetransformCmdcommand group, which formats an OpenAPI document to be more human-readable. [1] [2]cmd/openapi/transform.go: Implemented therunFormatfunction to handle the logic for the newformatCmdcommand.Tests for the new format command:
internal/transform/format_test.go: Added tests to verify the behavior of the newformatCmdcommand, ensuring that the formatted OpenAPI document matches the expected output.