The latest updates on your projects. Learn more about Vercel for Git ↗︎

Hi @sansyrox
I just wanted to check if you would accept this PR if I complete the code (obviously in an acceptable way)
Thanks
Dave

CodSpeed Performance Report

Merging #1024 will not alter performance

_{Comparing dave42w:static_files (adeba3c) with main (9a95611)}

Summary

✅ 146 untouched benchmarks

I've decided that set_static_files_directory is better as it does not imply you can/should add multiple static directories.

Also if the directory does not exist then throw an assertion is going to help resolve deployment issues quicker especially as it shows the exact path it's trying to use.

Hey @dave42w

Hi @sansyrox
I just wanted to check if you would accept this PR if I complete the code (obviously in an acceptable way)
Thanks
Dave

Apologies for missing this PR. Having a review now 😄

Alright, one question

What is the concern with

app.serve_directory(
    route="/test_dir",
    directory_path=os.path.join(current_file_path, "build"),
    index_file="index.html",
)

Apart from it not coming up in the search?

Alright, one question

What is the concern with

app.serve_directory(
    route="/test_dir",
    directory_path=os.path.join(current_file_path, "build"),
    index_file="index.html",
)

Apart from it not coming up in the search?

for me:

• not showing clearly enough in documentation
• not making it easy to have separate static directories for each subrouter
• clear, sane defaults that mean we can expect to have a static route and a static directory in an app reduces learning time

not showing clearly enough in documentation

Yes, this is very bad, and we should fix this!

not making it easy to have separate static directories for each subrouter

you can do subrouter.serve_directory(..) . But yes, we should update the docs again

clear, sane defaults that mean we can expect to have a static route and a static directory in an app reduces learning time

Maybe it does. But it also imposes opinions and structure on the developers. Robyn is made to be extensible. We can maybe improve the implementation of serve_directory to make it simpler but I am not super keen on fixing defaults until absolutely necessary.

not showing clearly enough in documentation

Yes, this is very bad, and we should fix this!

I tried and npm told me that it hated me and I should run away :-)

not making it easy to have separate static directories for each subrouter

you can do subrouter.serve_directory(..) . But yes, we should update the docs again

You can but it doesn't help you setup a sane way of doing this. So you have to dive much deeper.

clear, sane defaults that mean we can expect to have a static route and a static directory in an app reduces learning time

Maybe it does. But it also imposes opinions and structure on the developers. Robyn is made to be extensible. We can maybe improve the implementation of serve_directory to make it simpler but I am not super keen on fixing defaults until absolutely necessary.

I'm not sure that offering defaults counts as imposing :-)

I tried and npm told me that it hated me and I should run away :-)

I will do it then. Let me make an issue :D

I'm not sure that offering defaults counts as imposing :-)

Not always but here, we will be hardcoding a static folder path, no?

I tried and npm told me that it hated me and I should run away :-)

I will do it then. Let me make an issue :D

Thanks, seen it :-)

I'm not sure that offering defaults counts as imposing :-)

Not always but here, we will be hardcoding a static folder path, no?

Only hardcoded as a default argument.

I'm thinking that if you go for the defaults then the route is static within Robyn and prefix/static for subroutes

default directories to be something like

./static/robyn      # for the main app
./static/prefix      # one for each subroute

when we start supporting nested subroutes we would change to something like

./static/robyn                              # for the main app static files
./static/prefix1/robyn                    # for a subroute static files
./static/prefix1/prefix2/robyn      # for a nested subroute static files