Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are Previous PRDs Required? #244

Open
Witchblade101 opened this issue May 17, 2022 · 1 comment
Open

Are Previous PRDs Required? #244

Witchblade101 opened this issue May 17, 2022 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@Witchblade101
Copy link
Collaborator

Each release we make adds a folder to pysiaf/pysiaf/prd_data/JWST/. Are the previous PRDs in that folder necessary, or can we delete them? Especially old things like rehearsals. I'm worried that folder will just keep accumulating junk, or maybe future updates will be so rare it won't ever matter.

We should look into this post-commissioning.

@Witchblade101 Witchblade101 added the question Further information is requested label May 17, 2022
@Witchblade101
Copy link
Collaborator Author

Short answer: No.

Longer answer: Currently yes, because checks against a few of the earliest simulated PRDs are included in all of the Generate scripts.

I propose that we only include the current PRD in the future. The generate scripts should compare new values to the current PRD by default. We should add the capability for a user to use or compare against any PRD that they have locally.

OPSSOC PRDs are released every quarter. It's been requested (I think by Rob Douglas, and others) that we release a new PySIAF with each PRD release, even if there are no SIAF changes. This will also allow us to release code changes, as well as HST & Roman SIAF changes in a more timely manner. But JWST PRD SIAF directories are 4 MB each (and binary). I don't want PySIAF to keep growing for no useful reason.

I'll also open a Jira ticket for this, and get feedback from @mfixstsci and @mgennaro (others?)

@Witchblade101 Witchblade101 self-assigned this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant