Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-251: Optimal extraction support for MIRI LRS #8967

Draft
wants to merge 54 commits into
base: main
Choose a base branch
from
Draft

JP-251: Optimal extraction support for MIRI LRS #8967

wants to merge 54 commits into from
+5,111 −5,201

Commits on Nov 26, 2024

  1. Start extract1d refactor

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    4383065 View commit details
    Browse the repository at this point in the history

  2. Add test for custom extraction with polynomial limits

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a8dbdf2 View commit details
    Browse the repository at this point in the history

  3. Fix log message f-string

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d9e6ae9 View commit details
    Browse the repository at this point in the history

  4. Deduplicate extraction interface

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a2fb108 View commit details
    Browse the repository at this point in the history

  5. Remove image reference type

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    dfbcdba View commit details
    Browse the repository at this point in the history

  6. Separate IFU from slit extraction

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    812d769 View commit details
    Browse the repository at this point in the history

  7. Remove NIRISS SOSS references from slit extraction code

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    f8144f6 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary middleman function; condense input type checking

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a86cc63 View commit details
    Browse the repository at this point in the history

  9. Add helper functions for special extraction modes

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    9a1718f View commit details
    Browse the repository at this point in the history

  10. Clean up messages

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c6ab190 View commit details
    Browse the repository at this point in the history

  11. First version incorporating new extraction engine 

    Co-authored-by: Timothy D Brandt <[email protected]>
Co-authored-by: Timothy Brandt <[email protected]>
    @melanieclarke @t-brandt
    3 people committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    03161f7 View commit details
    Browse the repository at this point in the history

  12. Fix extraction limit defaults and partial pixel weights

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    1398b97 View commit details
    Browse the repository at this point in the history

  13. Npixels is sum of weights instead of sum of pixels with non-zero weight

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7bbdf01 View commit details
    Browse the repository at this point in the history

  14. Move profile and wavelength calculations out of integration loop

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    114d635 View commit details
    Browse the repository at this point in the history

  15. Tidying up

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ab36e44 View commit details
    Browse the repository at this point in the history

  16. Update unit tests for new extract1d

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e08d549 View commit details
    Browse the repository at this point in the history

  17. Add left/right limit handling, fix partial pixel weights

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    2fbbd96 View commit details
    Browse the repository at this point in the history

  18. Make polynomial coefficient definition backward compatible

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    94034e1 View commit details
    Browse the repository at this point in the history

  19. Clean up aperture definition, fix edge cases

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    67dd25b View commit details
    Browse the repository at this point in the history

  20. Coverage tests for step interface

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    1dafa87 View commit details
    Browse the repository at this point in the history

  21. Move aperture correction setup outside integration loop

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    1efd355 View commit details
    Browse the repository at this point in the history

  22. Return separate values from locn_from_wcs function

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b0bae12 View commit details
    Browse the repository at this point in the history

  23. Rename 'boxcar' extraction to 'box'

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    05fe833 View commit details
    Browse the repository at this point in the history

  24. Set up for future optimal extraction

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    3619098 View commit details
    Browse the repository at this point in the history

  25. Tidy up code organization, add docstrings

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c1cfb8d View commit details
    Browse the repository at this point in the history

  26. Code style fixes

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    cc9c9e3 View commit details
    Browse the repository at this point in the history

  27. Make sure background values are finite: they default to 0, not NaN

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    dc20470 View commit details
    Browse the repository at this point in the history

  28. More general check for unresampled nirspec data

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c2ac046 View commit details
    Browse the repository at this point in the history

  29. More robust file saving for containers

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    05a67cd View commit details
    Browse the repository at this point in the history

  30. Add option to save spatial profile

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    0fc2414 View commit details
    Browse the repository at this point in the history

  31. Add check for negative values in profile

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7fc72b5 View commit details
    Browse the repository at this point in the history

  32. Add option to save scene model

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    f7d72e2 View commit details
    Browse the repository at this point in the history

  33. Fix scene model default

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d28c6de View commit details
    Browse the repository at this point in the history

  34. Minor fixes for optimal extraction support

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a516113 View commit details
    Browse the repository at this point in the history

  35. Add check for missing variances

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    6eb3782 View commit details
    Browse the repository at this point in the history

  36. Adding unit tests for extraction

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    093ffce View commit details
    Browse the repository at this point in the history

  37. Add temporary fix for background fit test

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d4caa1e View commit details
    Browse the repository at this point in the history

  38. Coverage tests for extract1d

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a9e30e1 View commit details
    Browse the repository at this point in the history

  39. Better npixels estimate for optimal extraction; fix background fit test

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    26fbf06 View commit details
    Browse the repository at this point in the history

  40. More unit tests for extract_1d coverage

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c1bb7a4 View commit details
    Browse the repository at this point in the history

  41. Fix npixels for non-uniform weights

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    283bb89 View commit details
    Browse the repository at this point in the history

  42. More coverage tests

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    35feed2 View commit details
    Browse the repository at this point in the history

  43. More unit tests for extract

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    db3d7e0 View commit details
    Browse the repository at this point in the history

  44. Tests for extract_one_slit

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b875015 View commit details
    Browse the repository at this point in the history

  45. Add change log fragment

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    97313af View commit details
    Browse the repository at this point in the history

  46. Make some parameters for create_extraction keywords instead of args

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    fd3176b View commit details
    Browse the repository at this point in the history

  47. Test coverage for create_extraction and run_extract1d

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    326fb37 View commit details
    Browse the repository at this point in the history

  48. First version of PSF extraction, contains hacks 

    Co-authored-by: jemorrison <[email protected]>
    @melanieclarke @jemorrison
    melanieclarke and jemorrison committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    31234e6 View commit details
    Browse the repository at this point in the history

  49. Fix default locations for psf profile

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    10845dd View commit details
    Browse the repository at this point in the history

  50. Turn off aperture correction for optimal extraction

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e40c57e View commit details
    Browse the repository at this point in the history

  51. Add options for modeling a negative nod trace

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d21fa9b View commit details
    Browse the repository at this point in the history

  52. Keep 0s in profile and scene model

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a9e3a45 View commit details
    Browse the repository at this point in the history

  53. Don't default optimal extraction to background subtraction

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d19a2e1 View commit details
    Browse the repository at this point in the history

  54. Fix for ref names in extract params default

    @melanieclarke
    melanieclarke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ea069da View commit details
    Browse the repository at this point in the history