Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap "process_slit" in try/except for "extract_2d.nirspec.nrs_extract2d" #8964

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
11 changes: 10 additions & 1 deletion jwst/extract_2d/nirspec.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,16 @@

# Loop over all slit instances that are present
for slit in open_slits:
new_model, xlo, xhi, ylo, yhi = process_slit(input_model, slit, exp_type)
try:
new_model, xlo, xhi, ylo, yhi = process_slit(
input_model, slit, exp_type
)
except ValueError:
log.warning(

Check warning on line 90 in jwst/extract_2d/nirspec.py

View check run for this annotation

Codecov / codecov/patch

jwst/extract_2d/nirspec.py#L89-L90

Added lines #L89 - L90 were not covered by tests
'process_slit failed for slit/subarray {0}, '.format(slit.name)
+ 'probably because the cutout has no valid pixels'
Comment on lines +91 to +92
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a little simpler formatted as an f-string:

Suggested change
'process_slit failed for slit/subarray {0}, '.format(slit.name)
+ 'probably because the cutout has no valid pixels'
f'process_slit failed for slit {slit.name}, '
f'probably because the cutout has no valid pixels'

)
continue

Check warning on line 94 in jwst/extract_2d/nirspec.py

View check run for this annotation

Codecov / codecov/patch

jwst/extract_2d/nirspec.py#L94

Added line #L94 was not covered by tests

slits.append(new_model)
orig_s_region = new_model.meta.wcsinfo.s_region.strip()
Expand Down
Loading