Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ffmpeg version #266

Open
blackforest-tom opened this issue May 21, 2019 · 3 comments
Open

New ffmpeg version #266

blackforest-tom opened this issue May 21, 2019 · 3 comments

Comments

@blackforest-tom
Copy link

Hey,

just building with ffmpeg, downloaded from their original website. It breaks the build, since in newer ffmpeg versions, the libav constants have been prefixed by "AV_". I wrote a macro, checking for ffmpeg version, and edited audioencoder.cpp and videoencoder.cpp to use the appropriate constants.
Unfortunately, i cannot test this with older ffmpeg versions, nor verify that the version i am splitting the names for is the perfectly right one (i got the version number from other projects, who had to do similar). Do you want me to issue a pull-request, although i cannot verify 100% if all was done correctly?

@auscaster
Copy link
Member

auscaster commented May 21, 2019 via email

@mgyong
Copy link

mgyong commented Jun 24, 2019

@blackforest-tom Can you provide more details on your fix for building with newer version of ffmpeg? I am facing the same issues? Thankas

@blackforest-tom
Copy link
Author

blackforest-tom commented Jun 24, 2019

@mgyong Look at this PR: #267

PS: I eventually gave up on this, since you would have to use webrtc libraries from 2015, and their newer recording API changed completely. What i found from my research, if you want to record a live stream with a recent webrtc build, you will have to implement it on your own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants