Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/session readonly #25

Merged
merged 9 commits into from
Mar 23, 2024
Merged

Feat/session readonly #25

merged 9 commits into from
Mar 23, 2024

Conversation

wrjgold
Copy link
Contributor

@wrjgold wrjgold commented Mar 4, 2024

Description:
Adds an option to invite other users to a session as viewers (read-only mode) or editors.

Changes:

  • Upon invite request

    • Generates a session uuid
    • Generates 2 additional shorter ids (6 characters) for easier reference, one for viewer’s session and one for editor’s session
    • Saves the ids in a map object and stores in the document set object
    • Returns session uuid and read only status set as false
  • Upon join request

    • Matches input id with corresponding session uuid and read-only status
    • Returns session uuid and read only status set as false/true

@RichDom2185 RichDom2185 self-requested a review March 4, 2024 22:57
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this! I have a few comments below:

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this! I just have some questions below – then, let's merge all 3 PRs in one go after.

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 1dd65f9 into ng Mar 23, 2024
2 checks passed
@RichDom2185 RichDom2185 deleted the feat/session-readonly branch March 23, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants