Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSG module's rgb function #324

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix CSG module's rgb function #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/bundles/csg/functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* [Imports] */
import { primitives } from '@jscad/modeling';
import { colorize as colorSolid } from '@jscad/modeling/src/colors';
import { geom3 } from '@jscad/modeling/src/geometries';

Check warning on line 4 in src/bundles/csg/functions.ts

View workflow job for this annotation

GitHub Actions / Verify all tests pass and build success 

'geom3' is defined but never used
import {
measureBoundingBox,
type BoundingBox
Expand Down Expand Up @@ -674,8 +674,7 @@
throw new Error('RGB values must be between 0 and 255 (inclusive)');
}

return `#${redValue.toString(16)}${greenValue.toString(16)}
${blueValue.toString(16)}`;
return `#${redValue.toString(16)}${greenValue.toString(16)}${blueValue.toString(16)}`;
}

/**
Expand Down
Loading