Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve placement of model in curve3D render tab #219

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

sayomaki
Copy link
Contributor

@sayomaki sayomaki commented Sep 4, 2023

Description

This PR fixes #218 where the space usage of the model in the curve3D render output tab is not very optimised. I have shifted the design to a more top-bottom style (instead of the current left-right arrangement).

The changes have been tested and checked locally (see screenshot below):
Updated Design

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Changes have been tested locally, and all tests and lints passed with no additional warnings/errors introduced by the PR.

Checklist:

(Note: Some of the items are not applicable for this PR)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@RichDom2185 RichDom2185 merged commit e337c4a into source-academy:master Sep 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: curve: layout of animate_curve and animate_3D_curve
2 participants