Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURVE]: Cyclic imports #145

Open
Cloud7050 opened this issue Jul 10, 2022 · 3 comments
Open

[CURVE]: Cyclic imports #145

Cloud7050 opened this issue Jul 10, 2022 · 3 comments
Labels
Bug [Category] minor [Priority]

Comments

@Cloud7050
Copy link
Contributor

The linter is reporting cyclic imports between bundles/curve/curves_webgl.ts and bundles/curve/types.ts.

The latter defines the types DrawMode, ScaleMode, and CurveSpace, which are used in the former, but at the same time, the former builds up to defining Curve and CurveDrawn, which the latter needs. Some refactoring may be in order, to resolve this and better fit each file's purpose.

@Cloud7050 Cloud7050 added the Bug [Category] label Jul 10, 2022
@Cloud7050 Cloud7050 added the minor [Priority] label Sep 7, 2023
@martin-henz
Copy link
Member

The curve module will be replaced by plotly. We can remove curve once all missions/quests are migrated. We can then close this issue.

@RichDom2185
Copy link
Member

The curve module will be replaced by plotly. We can remove curve once all missions/quests are migrated. We can then close this issue.

Should we remove it? We can migrate to plotly for sure but I think it's worth keeping the "legacy" modules

@martin-henz
Copy link
Member

Yes, we can keep curve around. No need to rush removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug [Category] minor [Priority]
Projects
None yet
Development

No branches or pull requests

3 participants