Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider start method for containerized tool-info module #1103

Open
PhilippWendler opened this issue Nov 12, 2024 · 2 comments
Open

Consider start method for containerized tool-info module #1103

PhilippWendler opened this issue Nov 12, 2024 · 2 comments
Labels
container related to container mode

Comments

@PhilippWendler
Copy link
Member

For putting the tool-info module into a container, we start a separate Python worker process using the multiprocessing module. Right now, multiprocessing uses fork to start that process, but this will change to forkserver in Python 3.14. This might cause problems because the process starts with a clean state instead. Similarly, when we changed table-generator from fork to spawn in 1b5010f we also had to make some adjustments, so we should investigate what we need to do for the containerized tool-info module.

We can also consider using spawn as in table-generator, because forkserver should not bring any advantage to us (we only create one process).

@PhilippWendler PhilippWendler added the container related to container mode label Nov 12, 2024
@Stonebanks-js
Copy link

@PhilippWendler The current setup uses the fork start method for the Python multiprocessing module to spawn the Python worker process right ?

Can you tell me more information regarding the issue pls ?

@PhilippWendler
Copy link
Member Author

@Stonebanks-js Currently we use the default method of Python. Right now I do not know more than what I have written, this issue is mostly about needing to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container related to container mode
Development

No branches or pull requests

2 participants