Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buffer] indicate shared pool by putting a very small shared buffer pool size #3387

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Junchao-Mellanox
Copy link
Collaborator

What I did

Put a very small shared buffer pool size when shared pool is detected enabling.

Why I did it

Avoid a timing issue like following:

  1. the buffer pool sizes, xoff have initialized to 0, which means the shared headroom pool is disabled
  2. but the buffer profiles already indicate the shared headroom pool is enabled
  3. later on the buffer pool sizes are updated with xoff being non-zero

In case the orchagent starts handling buffer configuration between 2 and 3, it is inconsistent between buffer pools and profiles, which fails Mellanox SAI sanity check and causes orchagent abort

How I verified it

Manual test
Run sonic-mgmt regression

Details if related

@Junchao-Mellanox
Copy link
Collaborator Author

Hi @prsunny , could you please help review? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants