Only set OUTBOUND_CA_TO_PA attributes when needed #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
oleksandrivantsiv
approved these changes
Nov 20, 2024
Yakiv-Huryk
approved these changes
Nov 20, 2024
Signed-off-by: Lawrence Lee <[email protected]>
…into dash-pl-attr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3319
What I did
Only set SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_OVERLAY_DMAC and SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_USE_DST_VNET_VNI when provided in configs
Why I did it
These attributes are required for all scenarios and will cause SAI validation issues if set when not needed.
How I verified it
Details if related