Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit go mod replace #461

Open
4 tasks
colin-arnott-xero opened this issue Jun 22, 2022 · 1 comment
Open
4 tasks

audit go mod replace #461

colin-arnott-xero opened this issue Jun 22, 2022 · 1 comment

Comments

@colin-arnott-xero
Copy link
Contributor

colin-arnott-xero commented Jun 22, 2022 •
edited
Loading

In go modules, replace directives are at best viral. They tend to make adoption, upgrades, and package management harder than GOPATH. They are intended as an escape hatch for development, not a longterm resolution, and should not really ever be contained within public facing modules intended for consumption.

As such, I would like to use this issue audit the current list of requires, track upstream fixes, and if possible remove them entirely:

go.mod#replace
// pinned to solo-io's fork of cue version 308aee4ff0928a8e0ec25b9cbbdc445264038463
// note(ilackarms): this replace must be shared in any skv2-based go module due to incompatibility with upstream versions of cue
cuelang.org/go => github.com/solo-io/cue v0.4.1-0.20210623143425-308aee4ff092
github.com/docker/docker => github.com/moby/moby v0.7.3-0.20190826074503-38ab9da00309
k8s.io/apimachinery => k8s.io/apimachinery v0.19.6
k8s.io/client-go => k8s.io/client-go v0.19.6
  • cuelang.org/go
  • github.com/docker/docker
  • k8s.io/apimachinery
  • k8s.io/client-go
@colin-arnott-xero
Copy link
Contributor Author

colin-arnott-xero commented Jun 22, 2022 •
edited
Loading

cuelang.org/go

If solo-io is intending to hard fork cuelang.org/go, then this should become a full fork with a new module name, specifically github.com/solo-io/cue. (I am happy to assist.) Otherwise, can we document the issues that are being actively upstreamed?

github.com/docker/docker

There is no context given for what this is doing or why this is included.

k8s.io/...

It appears that we are pinning to an old version of kubernetes. This should no longer be necessary with go1.18 (or the correct exclude directives to ignore old versions of k8s.io/client-go.

colin-arnott-xero added a commit to colin-arnott-xero/solo-apis that referenced this issue Jun 22, 2022
@colin-arnott-xero
require not replace
777cb71 
As was done in solo-io/gloo, we should be using exclude directives that
mirror the deprecate functionality in go1.18. This block has been
borrowed wholesale from that repo.

As well, now instead of replacing k8s.io/client-go with the version that
we actually want, we can just require it. Other requires have been left
unmodified.

Updates solo-io#461.
@colin-arnott-xero colin-arnott-xero mentioned this issue Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colin-arnott-xero