Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/admin semantic table rows #5950

Commits on Nov 27, 2024

  1. Use semantic UI elements in admin table rows

    All over the new admin we use divs or simply text to display the
    resource and rely on a complex Stimulus click event handler to open the
    edit route. This is not semantic at all and makes it necessary to use a
    fully JS enabled browser under all circumstances to test the new admin
    interface which leads to flaky and slow tests.
    
    We should use links instead and probably remove the stimulus click event
    handler. Also, links are not visually highlighted, which leads to a11y
    issues. So, this commit adds underlines to links in table rows.
    
    solidusio#5944
    MadelineCollier committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    6bd7f5e View commit details
    Browse the repository at this point in the history
  2. Convert symbol columns to links in admin tables

    Previously, when provided a symbol, the admin table component would
    simply call `data.public_send(cell)` (with cell being the symbol). This
    would result in a basic string as the content of the table row.
    
    We want to stop relying on the additional Stimulus click handlers
    that captured those plain text clicks and redirected the users to
    wherever the `row_url` location was.
    
    Now, the `render_data_cell` method handles wrapping the plain text in a
    link, with the href being the `row_url` location. Symbols can still be
    provided as columns and the component takes care of generating the proper
    semantic UI elements for us.
    MadelineCollier committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    7e8a645 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. wip specs

    MadelineCollier committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    111c932 View commit details
    Browse the repository at this point in the history