Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vercel build not working because runtime config is set to node 16 #997

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

edivados
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

0.3.x does not work on node 16.

What is the new behavior?

Updated runtime config to node 18 on the vercel adapter.

Other information

fixes #983

@ryansolid ryansolid merged commit 7e178a3 into solidjs:main Aug 14, 2023
9 checks passed
@ryansolid
Copy link
Member

Thanks

@edivados edivados deleted the vercel-deploy branch August 14, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: SolidStart issue deploying to Vercel
2 participants