Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect bun/bunx in create-solid #993

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Conversation

colinhacks
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

The create-solid script detects when the user_agent start with bun. Both bun run and bunx set npm_config_user_agent. When Bun is detected, dependencies are installed with bun.

Other information

@ryansolid
Copy link
Member

ryansolid commented Aug 10, 2023

Thank you. I'm going to merge this but I'm unclear when we will release this. I've had a hell of a time getting the CLI to build properly even with all deps locked it builds incorrectly. Even pulled out into a separate repo. It builds but the code generated is broken.

So appreciate the patience.

@ryansolid ryansolid merged commit 9664f19 into solidjs:main Aug 10, 2023
10 checks passed
@colinhacks
Copy link
Contributor Author

No worries, thanks Ryan!

@colinhacks colinhacks deleted the detect-bun-pm branch August 17, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants