Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Double rendering #977

Closed
2 tasks done
MariuzM opened this issue Aug 9, 2023 · 5 comments
Closed
2 tasks done

[Bug?]: Double rendering #977

MariuzM opened this issue Aug 9, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@MariuzM
Copy link

MariuzM commented Aug 9, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

I have raised this issue here swordev/suid#251 but unsure if this is up to them or some issue with how SolidStart is rendering

Expected behavior 🤔

Should not render text twice

Steps to reproduce 🕹

No response

Context 🔦

No response

Your environment 🌎

No response

@MariuzM MariuzM added the bug Something isn't working label Aug 9, 2023
@MariuzM
Copy link
Author

MariuzM commented Aug 9, 2023

Wrapping its inside elements into {``} solved

    <Button variant="contained" onClick={() => setCount(count() + 1)}>
      {`Clicks1111: ${count()}`}
    </Button>

Is this a bug?

@ryansolid
Copy link
Member

It sounds like a hydration bug. Would love a quick reproduction so I can look at it.

@MariuzM
Copy link
Author

MariuzM commented Aug 10, 2023

@ryansolid thank you, https://github.com/MariuzM/test_solid

@BierDav
Copy link
Contributor

BierDav commented Aug 19, 2023

Jup can confirm, same issue in my project when mixing string and signal values together

@ryansolid
Copy link
Member

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See #1139 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants