[Bug]: context providers are lost during refetchRouteData and return undefined

[apatrida]

Duplicates

• I have searched the existing issues

Latest version

• I have tested the latest version

Current behavior 😯

If you add a context provider, say around all routes in root.tsx tree directly, or in a layout around all routes, then you can useContext to get the values provided just fine.

They work:

• in routeData function
• in body of component function
• in rendering
• in createEffect function
• in createResource function
• in onMount function

BUT, if you do something like:

<div onClick={() => { refetchRouteData() }}>
                CLICK ME TO REFETCH {data()}
</div>

Then during this refetch in the routeData call to useContext returns undefined during the lifecycle of the refetch.

Expected behavior 🤔

That if you can use useContext in route data at all, it should work for any time the route data function is called: first render, refetch, refetch by key

Steps to reproduce 🕹

Steps:

1. add a context provider around the component
2. add route data that useContext this context in a component, and log the value returned from useContext
3. add a click handler on a div in that component to refetchRouteData
4. click the div and watch the log message for useContext go from having a value previously to undefined during refetch

Context 🔦

If we want to inject context we have to be able to trust it everywhere, otherwise your code breaks. I.e. if I inject a API class that holds the configured API end points and want to use it everywhere, I need to reliably appear.

Your environment 🌎

MAC OS X
using solidjs create on a sample App with default settings and just doing steps above.

[apatrida]

Update, this is only if you construct routeData with context incorrectly. The bad model:

export function routeData() {
    return createRouteData(() => {
        const thing = useContext(...);
        ...
    });
}

and correct is to capture context outside of the returned function:

export function routeData() {
    const thing = useContext(...);

    return createRouteData(() => {
        ...
    });
}