Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Deno downloading error - npm package 'uWebSockets.js' does not exist #1530

Closed
2 tasks done
ben-laird opened this issue Jun 7, 2024 · 5 comments
Closed
2 tasks done
Labels
bug Something isn't working upstream Issue waiting on dependencies

Comments

@ben-laird
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

When using the basic Solid Start template with Typescript, running deno task dev will error with the following message:

error: npm package 'uWebSockets.js' does not exist.

Expected behavior 🤔

Deno should be able to download all dependencies listed in package.json and should start the development server

Steps to reproduce 🕹

Steps:

  1. run pnpm create solid and use any name
  2. select "Yes" when prompted for whether this is a Solid Start project
  3. select the "basic" template
  4. select "Yes" when prompted for whether to use TypeScript
  5. run deno task dev in the root directory of the new project
  6. observe error

Context 🔦

I'm playing around with Solid Start in personal web apps and wanted to know if it would work with Deno in development and not just in production. I can't assume it does even though Vite works with Deno because framework authors can still break that compatibility; I've found that to be the case with Astro, regrettably.

Potentially related issues:

There's a chance this bug is upstream, possibly with Vinxi, Nitro, or even with Deno. I just figured I'd start here since I can't exactly pinpoint where the bug actually happens; there's no stack trace or indication of what caused uWebSockets.js to even be included in the downloads.

package.json:

{
  "name": "example-basic",
  "type": "module",
  "scripts": {
    "dev": "vinxi dev",
    "build": "vinxi build",
    "start": "vinxi start",
    "version": "vinxi version"
  },
  "dependencies": {
    "@solidjs/meta": "^0.29.4",
    "@solidjs/router": "^0.13.3",
    "@solidjs/start": "^1.0.1",
    "solid-js": "^1.8.17",
    "vinxi": "^0.3.11"
  },
  "engines": {
    "node": ">=18"
  }
}

Your environment 🌎

$ system_profiler SPSoftwareDataType SPHardwareDataType: (partial)
Software:

    System Software Overview:

      System Version: macOS 14.3 (23D56)
      Kernel Version: Darwin 23.3.0

Hardware:

    Hardware Overview:

      Model Name: MacBook Pro
      Chip: Apple M3 Max
      Total Number of Cores: 14 (10 performance and 4 efficiency)
      Memory: 36 GB
      System Firmware Version: 10151.81.1

$ deno --version:
deno 1.44.0 (release, aarch64-apple-darwin)
v8 12.6.228.3
typescript 5.4.5

$ node --version:
v22.2.0

$ pnpm --version:
9.1.4
@ben-laird ben-laird added the bug Something isn't working label Jun 7, 2024
@Brendonovich
Copy link
Contributor

uWebSockets.js is included by crossws. You can replicate this error outside of start by running deno repl and entering import "npm:crossws".
Maybe Deno's npm: resolver doesn't take into account packages that have github: dependencies, since it seems to look for uWebSockets.js on npm?

@brenelz
Copy link
Contributor

brenelz commented Jun 18, 2024

yeah good call @Brendonovich. Maybe need to file a bug on the deno repo?

@vincentfretin
Copy link

@ryansolid ryansolid added the upstream Issue waiting on dependencies label Jun 18, 2024
@birkskyum
Copy link
Contributor

birkskyum commented Aug 6, 2024

@ben-laird , run pnpm i (or other pm) and then DENO_FUTURE=1 deno task dev

@ben-laird
Copy link
Author

Running DENO_FUTURE=1 deno task dev works as expected. I'll close this issue as completed if you'd like @birkskyum, since this is an upstream issue that's fixed in a future version of Deno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Issue waiting on dependencies
Projects
None yet
Development

No branches or pull requests

6 participants