Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: renderStream not working as expected in prod mode #1138

Closed
2 tasks done
r0skar opened this issue Dec 8, 2023 · 2 comments
Closed
2 tasks done

[Bug]: renderStream not working as expected in prod mode #1138

r0skar opened this issue Dec 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@r0skar
Copy link

r0skar commented Dec 8, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

When starting an app with renderStream the streaming is not working in prod mode. The page waits until the server has done its job before completing the request. It works fine in dev mode.

Expected behavior 🤔

It should work in prod and dev mode.

Context 🔦

I looked through a couple of things and noticed this old PR (#167). For whatever reason the headers in prod look like this : accept: 'image/avif,image/webp,*/*', and therefor the compression kicks in and prevents the streaming. If I disable the compression the issue is fixed and everything works perfect. I have patched the package and thats fine for my use case at the moment.

Your environment 🌎

OS: Linux
Binary: Node 20.0.9
OS: Linux
solid-js: "1.8.5",
solid-start: "0.3.10",
@r0skar r0skar added the bug Something isn't working label Dec 8, 2023
@lgrammel
Copy link

FYI I've observed that streaming does not work when using the solidstart-openai example from the Vercel AI SDK with pnpm build && pnm start (pnpm dev works fine): https://github.com/vercel/ai/tree/main/examples/solidstart-openai

@ryansolid
Copy link
Member

In setting up for SolidStart's next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See #1139 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants