Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP assignments: make navigation sensible and listing/editing uniform #5

Open
toraritte opened this issue May 19, 2023 · 1 comment
Labels

Comments

@toraritte
Copy link
Member

toraritte commented May 19, 2023

Similar to issue #2 "Make date input methods uniform", SIP assignments can be interacted with from different locations in Lynx and via different interfaces:

  1. By clicking "SIP Assignments" on the sidebar, one can query SIP assignments through certain criteria. The resulting table will show all matching SIP assignments, regardless of which client they belong to.

  2. By clicking on "Clients" on the sidebar, choosing a client from the dropdown, clicking "View Client", and then hitting "SIP Assignments". The table will show all SIP assignments for that particular client.

  3. By clicking on "Admin" on the sidebar, then on "Assignments" under "LYNX".

    Only mentioning this for completeness' sake as the SIP assignments there have no meaningful names (see issue #6 "Add proper string representation to database models") and no query interface at all, so it is almost useless at the moment. (TODO: It should also be called "SIP Assignments", instead of simply "Assignments".)

The problems:

  • The tables have similar information, but the order of the columns and some are missing.

    Examples:

    • The table through method 1. puts the "Instructor" in column 2, but the table in method 2. puts it into column 4.
    • The table through method 1. has a "Status" column, but the table in method 2. has an "Actions" column instead (and no status representation).
  • The interactive elements (i.e., controls) work differently and cause extra work.

    Examples:

    • To edit an assignment, on has to click on the status link in the table through method 1, whereas the table through method 2 has an "Edit" button. The former is unintuitive, but both methods direct the user to another page, even though anything should be editable through the listing pages (e.g., status & instructor dropdown).
    • The navigation also breaks when one edits an assignment in the table through method 1, because saving the edited page redirects to the table through method 2.
  • Missing functionality on the main interface.

    Examples:

    • Date cannot be emended.
    • Re-assignment is not possible.

    These are possible from the admin page or directly in the database, but none of these are fun.

@toraritte toraritte added enhancement New feature or request frontend labels May 19, 2023
@toraritte toraritte changed the title SIP assignments: allow changing status from listing page SIP assignments: make navigation sensible and listing/editing uniform May 19, 2023
@toraritte
Copy link
Member Author

Questions:

  • How to make re-usable UI components (i.e., once inserted, they would all behave the same, and one change would propagate to every instance)? (See issue Make date input methods uniform #2, item 2.)

  • Are there any merits to have a standalone edit page?

    The only one I can think of is that it may not be possible to make the editing of the assignment's text accessible in the list itself. Also, what would trigger saving the new information (e.g., when changing a dropdown)? What about adding an edit button for each row (e.g., pencil icon, but label "Edit" for JAWS) that would turn every element in the row editable, and saving it with a button?

@toraritte toraritte added help wanted Extra attention is needed for_stakeholders and removed help wanted Extra attention is needed labels May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant