Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why dont we return 404s for */speakers/* */sponsors/* */presentations/* pages? #103

Open
irabinovitch opened this issue Sep 14, 2023 · 3 comments
Assignees

Comments

@irabinovitch
Copy link
Collaborator

We dont seem to return 404 not found for pages in most case.

Any random string after /speakers, /sponsors/, /blog/, /presentations/, etc results in a page being rendered with content.

For example, I'd expect this to 404 but instead it returns the full list of speakers: http://www.socallinuxexpo.org/scale/13x/speakers/twitter.com/dontrebootme

Similarly https://www.socallinuxexpo.org/blog/this/is/not/a/real/url/ returns the content of /blogs/

Not a big deal, but looking at logs theres a constant stream of crawlers/bots just recursively looping over these non-existent pages. these pages are surprisingly expensive to generate from a memory standpoint. would be nice to just return a cheap/static "not found" page as well as proper 404 response code.

I also thinks this masks various bugs we have with speaker pages, which would be easier to find if we got a proper error.

@DrupalPhil
Copy link
Collaborator

Views in Drupal 7 just doesn't work that way.

Extra path components (separated by slashes) are ignored if they don't match a more specific menu entry. So if you have a menu entry for path xxx/yyy it'll also receive requests for xxx/yyy/zzz and xxx/yyy/zzz/aaa.

We can add logic either at the server-lever or in the code to redirect these additional params to the canonical but we'd need to do it on a case by case basis.

@sbibayoff
Copy link

sbibayoff commented Oct 4, 2023 via email

@DrupalPhil
Copy link
Collaborator

Good find. I'll take a look and see if it breaks anything first.

@DrupalPhil DrupalPhil reopened this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants