Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement turn counter overflow with Wish / Future moves #10700

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DaWoblefet
Copy link
Member

@DaWoblefet DaWoblefet commented Nov 27, 2024

Big credit to Anubis for assisting in research and Karthik for help in implementation.

One implementation quirk Showdown has is that we treat Team Preview and everything before the first move selection as "turn 0", instead of everything up to the second move selection as "turn 0" (i.e. the first turn). If that was implemented correctly, we probably wouldn't need the hardcodes we have for things like Burning Jealousy vs Download. However, there's a lot of stuff that looks like it depends on the current turn count implementation, so I didn't touch that and just tossed in some -1s where appropriate.

See discussion of this mechanic starting at this post: https://www.smogon.com/forums/threads/10350377

@DaWoblefet DaWoblefet changed the title Implement turn overflow with Wish / Future moves Implement turn counter overflow with Wish / Future moves Nov 27, 2024
data/conditions.ts Outdated Show resolved Hide resolved
data/moves.ts Outdated Show resolved Hide resolved
data/conditions.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants