Implement turn counter overflow with Wish / Future moves #10700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big credit to Anubis for assisting in research and Karthik for help in implementation.
One implementation quirk Showdown has is that we treat Team Preview and everything before the first move selection as "turn 0", instead of everything up to the second move selection as "turn 0" (i.e. the first turn). If that was implemented correctly, we probably wouldn't need the hardcodes we have for things like Burning Jealousy vs Download. However, there's a lot of stuff that looks like it depends on the current turn count implementation, so I didn't touch that and just tossed in some -1s where appropriate.
See discussion of this mechanic starting at this post: https://www.smogon.com/forums/threads/10350377