Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rfc30/compiletime benchmark to ci #2775

Open
wants to merge 76 commits into
base: main
Choose a base branch
from

Conversation

thomas-k-cameron
Copy link
Contributor

@thomas-k-cameron thomas-k-cameron commented Jun 14, 2023

Motivation and Context

Compile time benchmark was merged before but it was reverted as it was causing error.

This one has it's error fixed.

Test for this CI can be found here.

https://github.com/awslabs/smithy-rs/actions/runs/5299211765/jobs/9592047342

Testing

https://github.com/awslabs/smithy-rs/actions/runs/5299211765/jobs/9592047342

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thomas-k-cameron thomas-k-cameron marked this pull request as ready for review June 18, 2023 04:37
@thomas-k-cameron thomas-k-cameron requested review from a team as code owners June 18, 2023 04:37
@thomas-k-cameron
Copy link
Contributor Author

Hi,

The issue we had is fixed now.
You can find the test result here.
https://github.com/awslabs/smithy-rs/actions/runs/5299211765/jobs/9592047342

Test was done by adding a ci-action to ci.yml.
This is now removed from the PR.

@rcoh rcoh requested review from a team as code owners November 14, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants