-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument LambdaHandler
's' convert_event
function
#2684
base: main
Are you sure you want to change the base?
Instrument LambdaHandler
's' convert_event
function
#2684
Conversation
This would have come in handy when debugging #2676.
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, the URI here could be sensitive. So perhaps we shouldn't log it?
Let's change it so that the URI is logged only when the feature |
An alternative here is that we create a wrapper which is the union of all redactions that can be applied prior to routing. e.g. if operation A had path segment 0 sensitive and operation B had path segment 1 sensitive then prior to routing we redact both 0 and 1. |
That would be tricky to implement correctly; it wouldn't be as simple as maintaining a list of indices on sensitive path segments, since greedy labels can capture a different number of path segments each time. |
Isn't the join of two greedy labels the component wise Looking over the API, I think this is doable without much hassle. |
Yes that would work. E.g. with the two patterns:
where the
So upon receiving a request URI like |
This would have come in handy when debugging #2676.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.