Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterable support in FHIRSearch #172

Closed
dogversioning opened this issue Aug 13, 2024 · 4 comments
Closed

Iterable support in FHIRSearch #172

dogversioning opened this issue Aug 13, 2024 · 4 comments

Comments

@dogversioning
Copy link
Contributor

As discussed in #169, we would like to create a parallel set of functions inside of FHIRSearch that behave more like modern python iterables, shadowing existing functions for now in order to prevent breaking the API. The discussed approach is as follows:

@mikix : I might propose we add:

  • perform_iter() (generator for Bundles)
  • perform_resources_iter() (generator for Resources)
  • Update perform_resources() to follow Bundle links transparently (and return all resources found as one giant list)
  • Some way to navigate Bundle links manually in case you got you Bundle a different way (like a history operation, or just a Bundle read from disk or something).
@mikix
Copy link
Contributor

mikix commented Aug 22, 2024

@LanaNYC I may have a little time this week/next to look at this - just pinging because I didn't want to overlap efforts, in case you had started looking at this (you had mentioned maybe having time to look at this too, in your original pagination PR)

@LanaNYC
Copy link
Contributor

LanaNYC commented Aug 22, 2024

@mikix Hey, sorry for the delay — I started looking into it but got interrupted. I was planning to get back to it next week, but I don't want to hold you up. Let me know if you'd prefer to take it over.

@mikix
Copy link
Contributor

mikix commented Aug 22, 2024

@LanaNYC ah cool no - no worries about a delay, there's no schedule here. I was just reminded of this and was curious where your brain was at. If you're planning to look at this, go for it, and I'll happily review. If it does end up sliding off your plate, let me know and I can pick it back up.

@mikix
Copy link
Contributor

mikix commented Nov 6, 2024

Solved by #174 - will be in next release!

@mikix mikix closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants