Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hardcoded ports in firewalld.yml file #43

Open
JensMKofoed opened this issue Mar 7, 2023 · 0 comments
Open

Change hardcoded ports in firewalld.yml file #43

JensMKofoed opened this issue Mar 7, 2023 · 0 comments

Comments

@JensMKofoed
Copy link

JensMKofoed commented Mar 7, 2023

Hi,

Many thanks for a wonderful role for installing and configure zookeeper. It saves my hours to write my own.
A suggestions is to change the hardcoded ports in the firewalld.yml file:
From:
name: Add firewalld rules
firewalld:
port: "{{ item }}"
permanent: yes
state: enabled
loop:
- 2181/tcp
- 2888/tcp
- 3888/tcp
notify: Reload firewalld

To:
name: Add firewalld rules
firewalld:
port: "{{ item }}"
permanent: yes
state: enabled
with_items:
- "{{ (zookeeper_client_port }}/tcp"
- "{{ zookeeper_leader_port }}/tcp"
- "{{ zookeeper_election_port }}/tcp"
notify: Reload firewalld

Kind regards
Jens M. Kofoed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant