Skip to content
This repository has been archived by the owner on Jan 4, 2018. It is now read-only.

Do not slot empty or whitespace-only text nodes. #23

Open
treshugart opened this issue Mar 31, 2016 · 3 comments
Open

Do not slot empty or whitespace-only text nodes. #23

treshugart opened this issue Mar 31, 2016 · 3 comments

Comments

@treshugart
Copy link
Member

I don't want to have to do this, but I don't know of a good algorithm to determine if whitespace should be part of a slot. The problem comes when you write HTML; your indentation and new lines get treated as light DOM and slotted into a default slot unless you either require a named slot, or do this.

@treshugart
Copy link
Member Author

@nadiam84 what do you think about this? I know we've talked about it in the past. I don't believe the spec is particular about this.

@adevnadia
Copy link
Contributor

@treshugart since there is nothing about this in the spec, and since we have no obvious way to determine which decision would be right, I'd say go with the easiest solution. Which is leave things as they are now, i.e. don't slot empty text-nodes.

@treshugart
Copy link
Member Author

Sounds good to me :)

On Thu, 9 Jun 2016, 21:33 nadiam84 [email protected] wrote:

@treshugart https://github.com/treshugart since there is nothing about
this in the spec, and since we have no obvious way to determine which
decision would be right, I'd say go with the easiest solution. Which is
leave things as they are now, i.e. don't slot empty text-nodes.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#23 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAIVbAlkpLkuyLiPz1vIuQ95WXKwvs1Pks5qJ_oWgaJpZM4H8c-b
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants